Fix hashing context example #91920
Merged
Fix hashing context example #91920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
documentation
cherrypick:4.2
raulsntos
reviewed
May 14, 2024
There was a problem hiding this comment.
Thanks for contributing to the documentation!
CI is complaining about indentation. Make sure the code is indented with 4 spaces, unlike the rest of the XML file which uses tabs.
Also, the commit is linked to a different GitHub account than the one you used to submit the PR. This is fine, but I wanted to make sure it wasn't by mistake. For more information see: Why are my commits linked to the wrong user?
See which "email" you have configured currently: https://github.com/godotengine/godot/pull/91920.patch
dmipeck
force-pushed
the
fix-hashing-context-example
branch
4 times, most recently
from
e84a6f7 to
570455b
Compare
Example now works for any file size instead of just multiples of CHUNK_SIZE Example also uses correct method for looping over file data
dmipeck
force-pushed
the
fix-hashing-context-example
branch
from
570455b to
d6715b4
Compare
raulsntos
approved these changes
Jun 26, 2024
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example function produces invalid hashes for files that aren't a multiple of
CHUNK_SIZEbytes in sizeFixes two issues:
eof_reached()who's docs say to usefile.get_position() < file.get_len()instead when loopingCHUNK_SIZEifCHUNK_SIZEwould be too large